-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button in wrong language #1544
Open
t71rs
wants to merge
11
commits into
Stirling-Tools:main
Choose a base branch
from
t71rs:button-in-wrong-language
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Button in wrong language #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name/ No file selcted message not working yet
…o or more input forms on the screen
github-actions
bot
added
Front End
Issues or pull requests related to front-end development
Translation
labels
Jul 8, 2024
TheMattBin
approved these changes
Jul 20, 2024
@t71rs awesome change! but it seems like the submit button has changed its appearance somewhat, do we need to copy bootstraps exact CSS example for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Front End
Issues or pull requests related to front-end development
needs-changes
Stale
Issues or pull requests that have become inactive
Translation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made File Input Form translatable
The File Input form that is used by all pages, except view pdf and the multitool was not translatable. Since the form default form can not be made translatabel, I implemented a button that goes over it and looks exactly the same, that calls the file input form when clicked. The functionality and style of the button is identical to the original form. For refernece see picture of the new button:
Closes #1260
Checklist:
Contributor License Agreement
By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.
(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)