-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of NightWatch to latest Android API version #86
base: master
Are you sure you want to change the base?
Conversation
download not written
1) Add a preference for the Maximum BG value 2) Add a check for airplane mode when checking for missed data. (you don't want to alarm about missing data when the cause is airplane mode. I had this happen in a movie theater!)
of a point when it is selected.
Fix some of the new ShareRest interface
mobile/build.gradle
Outdated
defaultConfig { | ||
applicationId "com.dexdrip.stephenblack.nightwatch" | ||
minSdkVersion 15 | ||
minSdkVersion 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would exclude KitKat devices that is still the most popular Android version with NightWatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change it to 19 and test it tonight. I thought I had pulled it far enough back.
I don't have any kitkat devices so I can't test it there. Is it enough that it compiles and runs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't thinking - I created an emulated device with KitKat on it and tested it that way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok - so it is not going to be that easy. Updating the code to the AppCompatActivity places a bunch of library dependancies that is breaking the runtime. I am looking at it now but it is not something as easy as changing a number
I have to test the Share interface still it compiles but it has not been tested.
I have been using this version for a week or so and it has been running well.
I have added some functionality as well as getting it to compile/run in Android studio.
-- Delta shows under the reading age when raw is turned off.
-- You can change the max value of the graph in Settings->Bg Alerts Settings
-- Added - Settings->About to indicate SW Version