Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dimming of DSO hints and labels #3945

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

gzotti
Copy link
Member

@gzotti gzotti commented Oct 10, 2024

Description

When using proportional hints or DSO vector outlines, or also when just using many DSO, they appear too bright on screen.
This branch allows to reduce displayed brightness of hints (icons) and labels using two new spinboxes next to the DSO hint/label sliders.

Also, given that I simply want more modern UX where settings can be adjusted individually,
I allow immediate-storing of more DSO-related fine-tune view settings.
(These are still behind the power user tweak flag, config.ini:gui/immediate_save_details.)

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: Win10
  • Graphics Card: Geforce, but irrelevant.

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide --- NOT YET!
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

- also immediate store more DSO-related fine-tune view settings
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

src/core/modules/NebulaMgr.cpp Fixed Show fixed Hide fixed
src/core/modules/NebulaMgr.cpp Fixed Show fixed Hide fixed
- not /4, just /2 from master is OK for 100% (no) scaling.
- maybe needs HiDPI adjustment?
@alex-w
Copy link
Member

alex-w commented Oct 10, 2024

(Linux) 2K resolution:
stellarium-005
stellarium-006

(Linux) 4K resolution:
stellarium-007
stellarium-008

Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes is OK for me, but please check the conversion of variable types (float <-> double) - maybe using type double will be OK for all of them.

@alex-w alex-w added this to the 24.4 milestone Oct 10, 2024
@gzotti
Copy link
Member Author

gzotti commented Oct 10, 2024

Compare globular cluster diameters (infostring) with AngleMeasure result, and switch on DSS. In master the symbol is massively too large. It's less clear with galaxies, and debatable for some diffuse nebulae. These here are with current adjusted scaling on a non-HiDPI screen.
image

image
image

@gzotti
Copy link
Member Author

gzotti commented Oct 10, 2024

Yes, I have seen the warnings. Will fix that on weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants