-
-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dimming of DSO hints and labels #3945
base: master
Are you sure you want to change the base?
Conversation
- also immediate store more DSO-related fine-tune view settings
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
- not /4, just /2 from master is OK for 100% (no) scaling. - maybe needs HiDPI adjustment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes is OK for me, but please check the conversion of variable types (float <-> double) - maybe using type double will be OK for all of them.
Yes, I have seen the warnings. Will fix that on weekend. |
Description
When using proportional hints or DSO vector outlines, or also when just using many DSO, they appear too bright on screen.
This branch allows to reduce displayed brightness of hints (icons) and labels using two new spinboxes next to the DSO hint/label sliders.
Also, given that I simply want more modern UX where settings can be adjusted individually,
I allow immediate-storing of more DSO-related fine-tune view settings.
(These are still behind the power user tweak flag, config.ini:gui/immediate_save_details.)
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: