Fix code scanning alert no. 2: Prototype-polluting function #3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
Should be replaced by PR #3923 - a new version of RequireJS has this security fix. |
alex-w
added
the
state: published
|
Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Stellarium/stellarium/security/code-scanning/2
To fix the prototype pollution vulnerability in the
mixinfunction, we need to add checks to block the special properties__proto__andconstructor. This will prevent these properties from being copied from the source object to the target object, thereby mitigating the risk of prototype pollution.mixinfunction to include checks for__proto__andconstructorproperties.plugins/RemoteControl/webroot/js/require.jswithin themixinfunction.Suggested fixes powered by Copilot Autofix. Review carefully before merging.