Improve text rendering quality #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we switched to texture-based text rendering, colored text on bright background like direction markers on atmosphere background got a barely noticeable dark fringe. Using alpha channel rendered by QPainter doesn't seem to be easy to get right, so this commit instead uses the RGB channel of white text rendered on black background to get intensity to modulate text color by. The result is now closer to the one we got from QPainter over QOpenGLPaintEngine.
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
alex-w
approved these changes
Aug 6, 2023
alex-w
added
the
state: published
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @10110111! Please check the latest stable version of Stellarium: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After we switched to texture-based text rendering, colored text on bright background like direction markers on atmosphere background got a barely noticeable dark fringe.
Using alpha channel rendered by QPainter doesn't seem to be easy to get right, so this commit instead uses the RGB channel of white text rendered on black background to get intensity to modulate text color by.
The result is now closer to the one we got from QPainter over QOpenGLPaintEngine.
Screenshots
Before 1168932
Before this PR
After this PR
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: