-
-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a linear color space when rendering #3156
Closed
Closed
Commits on Jun 10, 2023
-
Remove support for luminance textures
They are not supported in OpenGL Core profile, and we don't have too many grayscale textures to make this worth the cost. The main problem with them is that they are incompatible with sRGB internal format that can let texture sampling automatically yield linear colors.
Configuration menu - View commit details
-
Copy full SHA for 46b44de - Browse repository at this point
Copy the full SHA 46b44deView commit details
Commits on Jun 11, 2023
-
Add support for sRGB-aware textures
Sampling from such textures will automatically convert sRGB-encoded data to linear color values. For now all modules will still treat textures the old way.
Configuration menu - View commit details
-
Copy full SHA for d8f9963 - Browse repository at this point
Copy the full SHA d8f9963View commit details -
Start converting the rendering process to linear-color FBO
All the rendering is now supposed to happen in linear-sRGB color space, and the OETF is applied at the end of rendering, followed by dithering.
Configuration menu - View commit details
-
Copy full SHA for f4be5bd - Browse repository at this point
Copy the full SHA f4be5bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for a30f0ee - Browse repository at this point
Copy the full SHA a30f0eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c652f9 - Browse repository at this point
Copy the full SHA 9c652f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d6b5c3 - Browse repository at this point
Copy the full SHA 6d6b5c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f19fe8 - Browse repository at this point
Copy the full SHA 7f19fe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06abb87 - Browse repository at this point
Copy the full SHA 06abb87View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.