Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fly and pattern feedback #255

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

reno-
Copy link

@reno- reno- commented Mar 21, 2022

I tried to implement fly and pattern feedback, but it does not compile with Xcode, with only one error that I don't know to get rid.
I hop that will help to implement feedback for 4.3 version !

@SteffeyDev
Copy link
Owner

Ok, all you have to do to get it to build is change

UpstreamKeyerFlyParametersMonitor::Notify(BMDSwitcherKeyFlyParametersEventType eventType)

to

UpstreamKeyerFlyParametersMonitor::Notify(BMDSwitcherKeyFlyParametersEventType eventType, BMDSwitcherFlyKeyFrame keyFrame)

in FeedbackMonitors.mm, and make a similar change in FeedbackMonitors.h by adding BMDSwitcherFlyKeyFrame keyFrame to the Notify function definition. I was able to get it to build with those two files. Please make that change and test to make sure all is working as expected.

@reno-
Copy link
Author

reno- commented Mar 23, 2022

Please make that change and test to make sure all is working as expected.
Thank you @SteffeyDev . I cannot access to an Atem until a few days, so I cannot test it now. But I will do it asap !

@reno-
Copy link
Author

reno- commented Sep 19, 2022

Hi @SteffeyDev , I just test with an Atem 2 M/E, and it works fine with these last changes you can safely merge it.
best !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants