Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add uninstall button to store #739

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add uninstall button to store #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
48f23fd
refactor: remove unused classnames
alvaro-cuesta Jan 2, 2025
ebc2f52
feat: add uninstall button to store
alvaro-cuesta Jan 2, 2025
bb69a9a
revert(48f23fd7): "refactor: remove unused classnames"
alvaro-cuesta Jan 17, 2025
3396928
revert(partial): restore "deckyStoreCardInstallContainer"
alvaro-cuesta Jan 17, 2025
cc89630
chore: remove unneeded formatting change
alvaro-cuesta Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 33 additions & 22 deletions frontend/src/components/store/PluginCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ButtonItem, Dropdown, Focusable, PanelSectionRow, SingleDropdownOption, SuspensefulImage } from '@decky/ui';
import { CSSProperties, FC, useState } from 'react';
import { DialogButton, Dropdown, Focusable, PanelSectionRow, SingleDropdownOption, SuspensefulImage } from '@decky/ui';
import { FC, useState } from 'react';
import { useTranslation } from 'react-i18next';
import { FaArrowDown, FaArrowUp, FaCheck, FaDownload, FaRecycle } from 'react-icons/fa';
import { FaArrowDown, FaArrowUp, FaCheck, FaDownload, FaRecycle, FaTrash } from 'react-icons/fa';

import { InstallType, Plugin } from '../../plugin';
import { StorePlugin, requestPluginInstall } from '../../store';
Expand Down Expand Up @@ -30,6 +30,7 @@ const PluginCard: FC<PluginCardProps> = ({ storePlugin, installedPlugin }) => {

const { t } = useTranslation();

// IMPORTANT! The `deckyStore*` classes below seem unused but they exist for theme developers
return (
<div
className="deckyStoreCard"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These classes seemed unused.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they exist for theme developers, keep them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AAGaming00 done. Also added a small warning documenting this.

Expand Down Expand Up @@ -140,20 +141,8 @@ const PluginCard: FC<PluginCardProps> = ({ storePlugin, installedPlugin }) => {
<div className="deckyStoreCardButtonRow">
<PanelSectionRow>
<Focusable style={{ display: 'flex', gap: '5px', padding: 0 }}>
<div
className="deckyStoreCardInstallContainer"
style={
{
paddingTop: '0px',
paddingBottom: '0px',
flexGrow: 1,
'--field-negative-horizontal-margin': 0,
} as CSSProperties
}
>
<ButtonItem
bottomSeparator="none"
layout="below"
<div className="deckyStoreCardInstallContainer" style={{ flexGrow: '1' }}>
<DialogButton
onClick={() =>
requestPluginInstall(storePlugin.name, storePlugin.versions[selectedOption], installType)
}
Expand Down Expand Up @@ -185,21 +174,43 @@ const PluginCard: FC<PluginCardProps> = ({ storePlugin, installedPlugin }) => {
</>
)}
</span>
</ButtonItem>
</DialogButton>
</div>
{installedPlugin && installedVersionIndex === selectedOption ? (
<DialogButton
style={{
display: 'flex',
justifyContent: 'center',
alignItems: 'center',
minWidth: '40px',
flex: '1 1',
padding: '0',
}}
onClick={() => {
DeckyPluginLoader.uninstallPlugin(
installedPlugin.name,
t('PluginLoader.plugin_uninstall.title', { name: installedPlugin.name }),
t('PluginLoader.plugin_uninstall.button'),
t('PluginLoader.plugin_uninstall.desc', { name: installedPlugin.name }),
);
}}
>
<FaTrash />
</DialogButton>
) : null}
<div className="deckyStoreCardVersionContainer" style={{ minWidth: '130px' }}>
<Dropdown
rgOptions={
storePlugin.versions.map((version, index) => ({
rgOptions={storePlugin.versions.map(
(version, index): SingleDropdownOption => ({
data: index,
label: (
<div style={{ display: 'flex', alignItems: 'center', gap: '5px' }}>
{version.name}
{installedPlugin && installedVersionIndex === index ? <FaCheck /> : null}
</div>
),
})) as SingleDropdownOption[]
}
}),
)}
menuLabel={t('PluginCard.plugin_version_label') as string}
selectedOption={selectedOption}
onChange={({ data }) => setSelectedOption(data)}
Expand Down
5 changes: 0 additions & 5 deletions frontend/src/components/store/Store.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,6 @@ const BrowseTab: FC<{ setPluginCount: Dispatch<SetStateAction<number | null>> }>

return (
<>
<style>{`
.deckyStoreCardInstallContainer > .Panel {
padding: 0;
}
`}</style>
{/* This should be used once filtering is added

<PanelSectionRow>
Expand Down