Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added saspy and sas_kernel to jupyterlab image #649

Merged
merged 11 commits into from
Aug 19, 2024

Conversation

mathis-marcotte
Copy link
Contributor

@mathis-marcotte mathis-marcotte commented Jul 17, 2024

Description

for https://jirab.statcan.ca/browse/BTIS-406

Tests / Quality Checks

Are there breaking changes?

Ask yourself the next question;

  • Do we want to maintain the previous image from which we had to do breaking changes from?

If no, then carry on. If yes, there is a breaking change and we want to maintain the previous image do the following

  • Create a new branch for the current version (ex v1) based off the current master/main branch
  • Increment the tag in the CI for pushes to master/main (v1 to v2)
  • Change the CI that on pushes to the newly created "v1" branch (the name of the newly created branch we want to maintain is) it will push to the ACR.

Automated Testing/build and deployment

  • Does the image pass CI successfully (build, pass vulnerability scan, and pass automated test suite)?
  • If new features are added (new image, new binary, etc), have new automated tests been added to cover these?
  • If new features are added that require in-cluster testing (e.g. a new feature that needs to interact with kubernetes), have you added the auto-deploy tag to the PR before pushing in order to build and push the image to ACR so you can test it in cluster as a custom image?

JupyterLab extensions

  • Are all extensions "enabled" (jupyter labextension list from inside the notebook)?

VS Code tests

  • Does VS Code open?
  • Can you install extensions?

Code review

  • Have you added the auto-deploy tag to your PR before your most recent push to this repo? This causes CI to build the image and push to our ACR, letting reviewers access the built image without having to create it themselves
  • Have you chosen a reviewer, attached them as a reviewer to this PR, and messaged them with the SHA-pinned image name for the final image to test on the dev cluster (e.g. k8scc01covidacrdev.azurecr.io/jupyterlab-cpu:746d058e2f37e004da5ca483d121bfb9e0545f2b)?

@mathis-marcotte mathis-marcotte added the auto-deploy Trigger manual CI steps for this PR label Jul 17, 2024
@mathis-marcotte mathis-marcotte marked this pull request as ready for review July 17, 2024 14:01
@mathis-marcotte mathis-marcotte marked this pull request as draft July 17, 2024 18:28
@mathis-marcotte mathis-marcotte marked this pull request as ready for review July 30, 2024 17:06
@mathis-marcotte mathis-marcotte marked this pull request as draft August 2, 2024 19:44
@bryanpaget bryanpaget deleted the branch master-2.0 August 9, 2024 12:41
@bryanpaget bryanpaget closed this Aug 9, 2024
@mathis-marcotte mathis-marcotte marked this pull request as ready for review August 19, 2024 11:54
@mathis-marcotte mathis-marcotte merged commit c4d8fb0 into master-2.0 Aug 19, 2024
6 checks passed
@mathis-marcotte mathis-marcotte deleted the add-saskernel-to-jupyter branch August 19, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-deploy Trigger manual CI steps for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants