Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rel="noreferrer noopener" to _blank links #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/events/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
<div class="description">
<h3><%= @event.starts_at.to_time.strftime('%b %d, %I:%M %p') %> &ndash; <%= @event.ends_at.to_time.strftime('%b %d, %I:%M %p') %></h3>
<p>
<div><span class="glyphicon glyphicon-map-marker"></span> <a target="_blank" href="http://maps.google.com/?q=<%= @event.address %>"><%= @event.address %></a></div>
<div><span class="glyphicon glyphicon-link"></span> <a target="_blank" href="<%= @event.url %>">More Info</a></div>
<div><span class="glyphicon glyphicon-map-marker"></span> <a target="_blank" rel="noreferrer noopener" href="http://maps.google.com/?q=<%= @event.address %>"><%= @event.address %></a></div>
<div><span class="glyphicon glyphicon-link"></span> <a target="_blank" rel="noreferrer noopener" href="<%= @event.url %>">More Info</a></div>
</p>
<%= markdown
.render(decorate_content_with_mentions(@event))
Expand Down
8 changes: 4 additions & 4 deletions app/views/layouts/application.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -144,16 +144,16 @@
<% end %>
<!-- End of Newsletter Sign-Up Form -->
<div class="logos text-center">
<a target="_blank" href="http://labor-party.com/">
<a target="_blank" rel="noreferrer noopener" href="http://labor-party.com/">
<%= image_tag "logos/labor-party-flat.png", :alt => "The Labor Party" %>
</a>
<a target="_blank" href="http://devict.org">
<a target="_blank" rel="noreferrer noopener" href="http://devict.org">
<%= image_tag "logos/devict-flat.png", :alt => "devICT" %>
</a>
<a target="_blank" href="http://www.wichitacf.org/">
<a target="_blank" rel="noreferrer noopener" href="http://www.wichitacf.org/">
<%= image_tag "logos/wichita-community-foundation-flat.png", :alt => "Wichita Community Foundation" %>
</a>
<a target="_blank" href="http://wichitachamber.org/">
<a target="_blank" rel="noreferrer noopener" href="http://wichitachamber.org/">
<%= image_tag "logos/wichita-chamber-of-commerce-flat.png", :alt => "Wichita Chamber of Commerce" %>
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/shared/_event.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<% end %>
<div class="body">
<h2 class="title"><%= link_to event_path(event) do %><%= event.title %><% end %></h2>
<div><span class="glyphicon glyphicon-map-marker"></span> <a target="_blank" href="http://maps.google.com/?q=<%= event.address %>"><%= event.address %></a></div>
<div><span class="glyphicon glyphicon-map-marker"></span> <a target="_blank" rel="noreferrer noopener" href="http://maps.google.com/?q=<%= event.address %>"><%= event.address %></a></div>
<div><span class="glyphicon glyphicon-time"></span> <%= event.starts_at.to_time.strftime('%b %d, %I:%M %p') %> &ndash; <%= event.ends_at.to_time.strftime('%b %d, %I:%M %p') %></div>
<!-- <div class="col-sm-12 col-md-4">
<%= simple_format(event.content) %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/shared/_markdown_help.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
*italics* or **bold**<br>
[Link text](link URL)<br>
!(image URL)[alt text]<br>
You can also insert most html. For more detailed instructions look at <a href="https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet" target="_blank">this cheat sheet</a>.
You can also insert most html. For more detailed instructions look at <a href="https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet" target="_blank" rel="noreferrer noopener">this cheat sheet</a>.
</div>
2 changes: 1 addition & 1 deletion app/views/shared/_person_edit_form.html.erb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<%= f.hidden_field :user_id %>

<div class="form-group">
<img src="<%= profile_image(f.object) %>" alt="" class="profile-img img-circle img-responsive" style="float: left; margin: 5px;"><h3>Your face here</h3><p>If you already have a Gravatar set up with the email address in your profile, you're done! If not, you can <a target="_blank" href="https://signup.wordpress.com/signup/?ref=oauth2&oauth2_redirect=49608c71729e59cdfaf9388e01e03d91%40https%3A%2F%2Fpublic-api.wordpress.com%2Foauth2%2Fauthorize%2F%3Fclient_id%3D1854%26response_type%3Dcode%26blog_id%3D0%26state%3Dccda9f0e7803fd4134e79e60f8aa527cf5835a1ef6ea2e634d313f3ad992e36a%26redirect_uri%3Dhttps%253A%252F%252Fen.gravatar.com%252Fconnect%252F%253Faction%253Drequest_access_token%26jetpack-code%26jetpack-user-id%3D0%26action%3Doauth2-login&wpcom_connect=1">click here to set that up.</a></p>
<img src="<%= profile_image(f.object) %>" alt="" class="profile-img img-circle img-responsive" style="float: left; margin: 5px;"><h3>Your face here</h3><p>If you already have a Gravatar set up with the email address in your profile, you're done! If not, you can <a target="_blank" rel="noreferrer noopener" href="https://signup.wordpress.com/signup/?ref=oauth2&oauth2_redirect=49608c71729e59cdfaf9388e01e03d91%40https%3A%2F%2Fpublic-api.wordpress.com%2Foauth2%2Fauthorize%2F%3Fclient_id%3D1854%26response_type%3Dcode%26blog_id%3D0%26state%3Dccda9f0e7803fd4134e79e60f8aa527cf5835a1ef6ea2e634d313f3ad992e36a%26redirect_uri%3Dhttps%253A%252F%252Fen.gravatar.com%252Fconnect%252F%253Faction%253Drequest_access_token%26jetpack-code%26jetpack-user-id%3D0%26action%3Doauth2-login&wpcom_connect=1">click here to set that up.</a></p>

<button class="btn btn-primary" type="button" data-toggle="collapse" data-target="#collapseExample" aria-expanded="false" aria-controls="collapseExample">
No, I really, really want to upload an image instead of amazing web services.
Expand Down
2 changes: 1 addition & 1 deletion app/views/tuesday_mailer/send_newsletters.html.erb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<h1>Greetings Wichita-ites!</h1>
This Tuesday Newsletter will keep you updated to the upcoming Events and News recently posted on our site.
<br />
Stay up to date by stopping by <a href="<%= @http_host %>" target="_blank">StartupWichita</a> anytime!
Stay up to date by stopping by <a href="<%= @http_host %>" target="_blank" rel="noreferrer noopener">StartupWichita</a> anytime!
<br />
<% unless @recent_news.blank? %>
<h2>Recently Published News:</h2>
Expand Down