Add event voting #127
Merged
Add event voting #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much @cheshire137! |
|
Yep, that's easy enough! |
|
This now only has upvoting. I renamed it to "recommend" because it felt odd to have just a "like" button by itself. When the user has upvoted:
When the user has not upvoted:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses #7 by allowing users to vote on events. You can only vote on events you can't edit, meaning you can't vote on your own event. This uses the acts_as_votable gem.
This branch only gives the ability to vote up or down on events. It doesn't provide an index view of events sorted by votes. I wanted to keep the PR diff small, so I think a) voting on records other than events and b) sorting records based on votes could come in separate branches.
I felt upvoting and downvoting looked better with the thumbs up and thumbs down Glyphicons, so I changed the "Flag as Spam" glyphicon to be the circle with a slash in it, instead of the thumbs down.
I noticed when I ran
rake spec, indication_spec.rb was erroring out because it required a nonexistent rails_helper file. So I updated it to require the spec_helper that other tests require.