Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Company model #124

Closed
wants to merge 15 commits into from
Closed

Add Company model #124

wants to merge 15 commits into from

Conversation

cesc1989
Copy link

@cesc1989 cesc1989 commented Oct 12, 2017

This PR implements #14

@kentonh I'd like you to please review this before merging (I mean in your local environment). There's something about the navbar I don't like.

When adding a Companies link to the navbar, there's no space for it to fit horizontally. I see no padding or marging to remove except for the one of the bootstrap class. Maybe reducing font-size or reducing the bootstrap class margin and padding? Not sure.

Moreover, Do I need to set a User -> Company association?

Looking forward for your comments.

@kentonh
Copy link
Member

kentonh commented Oct 15, 2017

@cesc1989 Thanks for this!

Resources aren't really used at this time, and my plan was to Resources from the nav bar, and use the same icon for Companies.

In my test environment, I didn't see a place to add companies. How is that accomplished?

@cesc1989
Copy link
Author

Resources aren't really used at this time, and my plan was to Resources from the nav bar, and use the same icon for Companies

Got you.

In my test environment, I didn't see a place to add companies. How is that accomplished?

I'll check controller/views I followed for Companies and let you know in a couple of hours.

Thank you for your feedback, @kentonh

@cesc1989
Copy link
Author

@kentonh changed resources link with companies one. Companies uses the icon resources had.

In order for you to see the add company link, you should be logged in and be an admin.

image

@cesc1989 cesc1989 closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants