Bump minitest from 5.25.5 to 5.26.1 #825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [minitest](https://github.com/minitest/minitest) from 5.25.5 to 5.26.1. - [Changelog](https://github.com/minitest/minitest/blob/master/History.rdoc) - [Commits](minitest/minitest@v5.25.5...v5.26.1) --- updated-dependencies: - dependency-name: minitest dependency-version: 5.26.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
gem compare minitest 5.25.5 5.26.1Compared versions: ["5.25.5", "5.26.1"]
DIFFERENT date:
5.25.5: 2025-03-12 00:00:00 UTC
5.26.1: 1980-01-02 00:00:00 UTC
DIFFERENT required_ruby_version:
5.25.5: >= 2.7, < 4.0
5.26.1: >= 2.7
DIFFERENT rubygems_version:
5.25.5: 3.6.3
5.26.1: 3.7.2
DIFFERENT version:
5.25.5: 5.25.5
5.26.1: 5.26.1
DIFFERENT files:
5.25.5->5.26.1:
* Changed:
History.rdoc +32/-0
README.rdoc +7/-2
Rakefile +1/-2
design_rationale.rb +21/-19
lib/minitest.rb +21/-18
lib/minitest/assertions.rb +3/-8
lib/minitest/parallel.rb +2/-0
lib/minitest/spec.rb +6/-4
lib/minitest/test.rb +1/-0
lib/minitest/test_task.rb +26/-4
test/minitest/test_minitest_assertions.rb +3/-3
test/minitest/test_minitest_spec.rb +9/-11
test/minitest/test_minitest_test.rb +1/-1
DIFFERENT extra_rdoc_files:
5.25.5->5.26.1:
* Changed:
History.rdoc +32/-0
README.rdoc +7/-2
DIFFERENT development dependencies:
5.25.5->5.26.1:
* Updated:
hoe from: ["~> 4.2"] to: ["~> 4.3"] |
gem compare --diff minitest 5.25.5 5.26.1Compared versions: ["5.25.5", "5.26.1"]
DIFFERENT files:
5.25.5->5.26.1:
* Changed:
History.rdoc
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/History.rdoc 2025-11-10 03:01:49.372463551 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/History.rdoc 2025-11-10 03:01:49.379463595 +0000
@@ -0,0 +1,32 @@
+=== 5.26.1 / 2025-11-08
+
+The Ocean Shores, Slightly Less Tipsy Edition!
+
+* 3 bug fixes:
+
+ * Add links to API doco in README.
+ * Add missing require thread.
+ * Bumped ruby version to include 4.0 (trunk). (hsbt)
+ (see also 5.14.2)
+
+=== 5.26.0 / 2025-10-07
+
+The Seattle.rb Nerd Party, Slightly Tipsy Edition!
+
+* 2 minor enhancements:
+
+ * Added extra documentation to Minitest::TestTask options.
+ * Make parallelize_me! a no-op when n_threads=1.
+
+* 9 bug fixes:
+
+ * Bypass parallel_executor entirely when n_threads=1.
+ * Don't require rubygems in Rakefile... it is 2025.
+ * Ensure that minitest exits non-zero on Interrupt. (tavianator)
+ * Fix Minitest.run sequence rdoc to include loop vars and read consistently.
+ * Fix call to parallel_executor.shutdown when it isn't defined.
+ * Removed some 1.8/1.9-based code from the assertions and expectations.
+ * Still fighting with rdoc? Yup. Still fighting with rdoc...
+ * Switched assert_equal's diff from Tempfile.open to Tempfile.create.
+ * Use Regexp.escape for BASE_RE in case pwd has special chars. (astra_1993)
+
README.rdoc
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/README.rdoc 2025-11-10 03:01:49.373463557 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/README.rdoc 2025-11-10 03:01:49.379463595 +0000
@@ -98 +98,3 @@
-Define your tests as methods beginning with +test_+.
+Define your tests as methods beginning with +test_+. Use
+{assertions}[/minitest/Minitest/Assertions.html] to test for results
+or state.
@@ -121,0 +124,3 @@
+Use {expectations}[/minitest/Minitest/Expectations.html] to check
+results or state. They must be wrapped in a value call (eg +_+).
+
@@ -149 +154 @@
-Add benchmarks to your tests.
+Add {benchmarks}[/minitest/Minitest/Benchmark.html] to your tests.
Rakefile
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/Rakefile 2025-11-10 03:01:49.373463557 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/Rakefile 2025-11-10 03:01:49.379463595 +0000
@@ -3 +2,0 @@
-require "rubygems"
@@ -15 +14 @@
- require_ruby_version [">= 2.7", "< 4.0"]
+ require_ruby_version ">= 2.7"
design_rationale.rb
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/design_rationale.rb 2025-11-10 03:01:49.373463557 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/design_rationale.rb 2025-11-10 03:01:49.379463595 +0000
@@ -5,11 +4,0 @@
- do_some_setup # super
- end # do_some_setup
- # end
- it "should do the first thing" do #
- 1.must_equal 1 # def test_first_thing
- end # assert_equal 1, 1
- # end
- describe SubThingy do # end
- before do #
- do_more_setup # class TestSubThingy < TestThingy
- end # def setup
@@ -17,6 +6,6 @@
- it "should do the second thing" do # do_more_setup
- 2.must_equal 2 # end
- end #
- end # def test_second_thing
-end # assert_equal 2, 2
- # end
+ do_some_setup # do_some_setup
+ end # end
+ #
+ it "should do the first thing" do # def test_first_thing
+ _(1).must_equal 1 # assert_equal 1, 1
+ end # end
@@ -23,0 +13,13 @@
+ #
+ describe SubThingy do # class TestSubThingy < TestThingy
+ before do # def setup
+ # super
+ do_more_setup # do_more_setup
+ end # end
+ #
+ it "should do the second thing" do # def test_second_thing
+ _(2).must_equal 2 # assert_equal 2, 2
+ end # end
+ end # end
+end #
+ #
@@ -36 +38 @@
- assert_equal 1, 1
+ _(1).must_equal 1
@@ -50 +52 @@
- assert_equal 2, 2
+ _(2).must_equal 2
lib/minitest.rb
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/lib/minitest.rb 2025-11-10 03:01:49.374463564 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/lib/minitest.rb 2025-11-10 03:01:49.380463602 +0000
@@ -13 +13 @@
- VERSION = "5.25.5" # :nodoc:
+ VERSION = "5.26.1" # :nodoc:
@@ -39 +39 @@
- self.parallel_executor = Parallel::Executor.new n_threads
+ self.parallel_executor = Parallel::Executor.new n_threads if n_threads > 1
@@ -262 +262 @@
- # Runnable.runnables.each
+ # Runnable.runnables.each |runnable_klass|
@@ -264,4 +264,5 @@
- # self.runnable_methods.each
- # self.run_one_method(self, runnable_method, reporter)
- # Minitest.run_one_method(klass, runnable_method)
- # klass.new(runnable_method).run
+ # filtered_methods = runnable_methods.select {...}.reject {...}
+ # filtered_methods.each |runnable_method|
+ # runnable_klass.run_one_method(self, runnable_method, reporter)
+ # Minitest.run_one_method(runnable_klass, runnable_method)
+ # runnable_klass.new(runnable_method).run
@@ -288,0 +290 @@
+ finished = true
@@ -292 +294 @@
- self.parallel_executor.shutdown
+ self.parallel_executor.shutdown if parallel_executor.respond_to? :shutdown
@@ -299,2 +301,2 @@
- return empty_run! options if summary && summary.count == 0
- reporter.passed?
+ return empty_run! options if finished && summary && summary.count == 0
+ finished and reporter.passed?
@@ -411,0 +414 @@
+ # at most 1-2% slower than a 1-pass version, stop optimizing this
@@ -575 +578 @@
- end
+ end # Runnable
@@ -627 +630 @@
- end
+ end # Reportable
@@ -681 +684 @@
- end
+ end # Result
@@ -731 +734 @@
- end
+ end # AbstractReportera
@@ -886 +889 @@
- end
+ end # StatisticsReporter
@@ -964 +967 @@
- end
+ end # SummaryReporter
@@ -1015 +1018 @@
- end
+ end # CompositeReporter
@@ -1082 +1085 @@
- BASE_RE = %r%#{Dir.pwd}/% # :nodoc:
+ BASE_RE = %r%#{Regexp.escape Dir.pwd}/% # :nodoc:
lib/minitest/assertions.rb
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/lib/minitest/assertions.rb 2025-11-10 03:01:49.374463564 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/lib/minitest/assertions.rb 2025-11-10 03:01:49.380463602 +0000
@@ -65 +65 @@
- Tempfile.open "expect" do |a|
+ Tempfile.create "expect" do |a|
@@ -69 +69 @@
- Tempfile.open "butwas" do |b|
+ Tempfile.create "butwas" do |b|
@@ -503,3 +503 @@
- rescue ThreadError => e # wtf?!? 1.8 + threads == suck
- default += ", not :#{e.message[/uncaught throw \`(\w+?)\'/, 1]}"
- rescue ArgumentError => e # 1.9 exception
+ rescue ArgumentError => e # 1.9+ exception
@@ -508,3 +505,0 @@
- rescue NameError => e # 1.8 exception
- raise e unless e.name == sym
- default += ", not #{e.name.inspect}"
lib/minitest/parallel.rb
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/lib/minitest/parallel.rb 2025-11-10 03:01:49.375463570 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/lib/minitest/parallel.rb 2025-11-10 03:01:49.382463614 +0000
@@ -0,0 +1,2 @@
+require "thread"
+
lib/minitest/spec.rb
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/lib/minitest/spec.rb 2025-11-10 03:01:49.376463576 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/lib/minitest/spec.rb 2025-11-10 03:01:49.382463614 +0000
@@ -41 +41,5 @@
-Minitest::Expectation = Struct.new :target, :ctx # :nodoc:
+# :stopdoc:
+module Minitest # fucking hell rdoc...
+ Expectation = Struct.new :target, :ctx
+end
+# :startdoc:
@@ -288,3 +292 @@
- def to_s # :nodoc:
- name # Can't alias due to 1.8.7, not sure why
- end
+ alias to_s name
lib/minitest/test.rb
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/lib/minitest/test.rb 2025-11-10 03:01:49.376463576 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/lib/minitest/test.rb 2025-11-10 03:01:49.382463614 +0000
@@ -60,0 +61 @@
+ return unless Minitest.parallel_executor
lib/minitest/test_task.rb
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/lib/minitest/test_task.rb 2025-11-10 03:01:49.376463576 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/lib/minitest/test_task.rb 2025-11-10 03:01:49.382463614 +0000
@@ -47,2 +47,10 @@
- # Create several test-oriented tasks under +name+. Takes an
- # optional block to customize variables.
+ # Create several test-oriented tasks under +name+ (default:
+ # "test"). Takes an optional block to customize variables.
+ # Examples:
+ #
+ # Minitest::TestTask.create # named "test", all defaults
+ #
+ # Minitest::TestTask.create do |t|
+ # t.warning = false # my tests are noisy
+ # t.framework = %(require_relative "./test/helper.rb")
+ # end
@@ -72 +80,5 @@
- # minitest/autorun...
+ # minitest/autorun.
+ #
+ # If you have a test helper file that requires minitest/autorun
+ # and anything else your project standardizes on, then you'll
+ # probably want to change this to:
@@ -74 +86,6 @@
- # Why do I have this as an option?
+ # Minitest::TestTask.create do |t|
+ # t.framework = %(require_relative "./test/helper.rb")
+ # end
+ #
+ # or something similar. NOTE: if you do this, then helper must
+ # require "minitest/autorun" at the top to start the tests.
@@ -102,0 +120,5 @@
+ # Example:
+ #
+ # Minitest::TestTask.create "test:cov" do |t|
+ # t.test_prelude = %(require "simplecov")
+ # end
test/minitest/test_minitest_assertions.rb
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/test/minitest/test_minitest_assertions.rb 2025-11-10 03:01:49.377463583 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/test/minitest/test_minitest_assertions.rb 2025-11-10 03:01:49.383463621 +0000
@@ -321 +321 @@
- msg = <<~EOM
+ msg = <<~'EOM' # NOTE: single quotes on heredoc
@@ -325 +325 @@
- -"A\\n
+ -"A\n
@@ -327 +327 @@
- +"A\\n\\\\nB"
+ +"A\n\\nB"
test/minitest/test_minitest_spec.rb
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/test/minitest/test_minitest_spec.rb 2025-11-10 03:01:49.378463589 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/test/minitest/test_minitest_spec.rb 2025-11-10 03:01:49.384463627 +0000
@@ -111 +111 @@
- @assertion_count = 2
+ @assertion_count -= 2
@@ -713,2 +712,0 @@
- i_suck_and_my_tests_are_order_dependent!
-
@@ -725 +723 @@
- _(_count).must_equal 0
+ exp = _count + 1
@@ -727,2 +725,2 @@
- _(count).must_equal 1
- _(count).must_equal 1
+ _(count).must_equal exp
+ _(count).must_equal exp
@@ -730 +728 @@
- _(_count).must_equal 1
+ _(_count).must_equal exp
@@ -734 +732 @@
- _(_count).must_equal 1
+ exp = _count + 1
@@ -736,2 +734,2 @@
- _(count).must_equal 2
- _(count).must_equal 2
+ _(count).must_equal exp
+ _(count).must_equal exp
@@ -739 +737 @@
- _(_count).must_equal 2
+ _(_count).must_equal exp
test/minitest/test_minitest_test.rb
--- /tmp/d20251110-2295-6h2no4/minitest-5.25.5/test/minitest/test_minitest_test.rb 2025-11-10 03:01:49.378463589 +0000
+++ /tmp/d20251110-2295-6h2no4/minitest-5.26.1/test/minitest/test_minitest_test.rb 2025-11-10 03:01:49.384463627 +0000
@@ -665 +665 @@
- skip if Minitest.parallel_executor.size < 2 # locks up test runner if 1 CPU
+ skip unless Minitest.parallel_executor # locks up test runner if 1 CPU
|
Contributor
Author
|
Superseded by #827. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps minitest from 5.25.5 to 5.26.1.
Changelog
Sourced from minitest's changelog.
Commits
15265daprepped for release7b2e090- Bumped ruby version to include 4.0 (trunk). (hsbt)c54c262Ryan! STAHP! Stop trying to "optimize" this.690d38a- Add links to API doco in README.d80a4fdComment end of larger classes w/ name to help navigation.8d4cf64Fix formatting of design_rationale.rb, update specs0db7aactweak assertion count to be consistent2f0848a- Add missing require thread.f78aa72prepped for release5faf12f- Use Regexp.escape for BASE_RE in case pwd has special chars. (astra_1993)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)