Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Support non deterministic functions in transparent mv #55662

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Feb 7, 2025

Why I'm doing:

A transparent mv is defined when mv's 'transparent_mv_rewrite_mode' property is true. when user querys a transparent mv, optimizer will redirect query into refreshed mv partitions from mv and unrefreshed partitions from query by union all.

Since transparent mv no needs to query rewrite, so it's fine to support non deterministic functions in transparent mv.

What I'm doing:

  • Disable checking deterministic functions in transparent mv's getting plan.

Fixes #55509

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@LiShuMing LiShuMing requested review from a team as code owners February 7, 2025 07:53
@LiShuMing LiShuMing requested a review from a team as a code owner February 8, 2025 06:13
@LiShuMing LiShuMing force-pushed the fix_transparent_mv_with_nondeterministic branch from c479b33 to 5be9108 Compare February 8, 2025 07:46
Signed-off-by: shuming.li <[email protected]>
Copy link

github-actions bot commented Feb 8, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Feb 8, 2025

[FE Incremental Coverage Report]

pass : 96 / 105 (91.43%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/MaterializedViewTransparentRewriteRule.java 6 9 66.67% [109, 149, 153]
🔵 com/starrocks/sql/optimizer/rule/NonDeterministicVisitor.java 7 10 70.00% [73, 172, 187]
🔵 com/starrocks/qe/ConnectContext.java 17 18 94.44% [1308]
🔵 com/starrocks/sql/optimizer/rewrite/OptConstFoldRewriter.java 46 48 95.83% [40, 59]
🔵 com/starrocks/catalog/MvPlanContext.java 4 4 100.00% []
🔵 com/starrocks/sql/optimizer/MaterializedViewOptimizer.java 12 12 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/rule/TextMatchBasedRewriteRule.java 1 1 100.00% []
🔵 com/starrocks/sql/analyzer/AnalyzerUtils.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/MvPlanContextBuilder.java 1 1 100.00% []

Copy link

github-actions bot commented Feb 8, 2025

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant