Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] reset the start time before execution (backport #55433) #55468

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 26, 2025

Why I'm doing:

What I'm doing:

AnalyzeStatus.StartTime should count from the beginning of execution rather than pending. For certain cases it can pend in the queue for a long time.

Fixes #55447

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link
Contributor Author

mergify bot commented Jan 26, 2025

Cherry-pick of 3ac86d6 has failed:

On branch mergify/bp/branch-3.2/pr-55433
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit 3ac86d6cff.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/statistic/AnalyzeStatus.java
	modified:   fe/fe-core/src/main/java/com/starrocks/statistic/ExternalAnalyzeStatus.java
	modified:   fe/fe-core/src/main/java/com/starrocks/statistic/NativeAnalyzeStatus.java

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/statistic/StatisticsCollectionTrigger.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jan 26, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 26, 2025 13:11
@mergify mergify bot closed this Jan 26, 2025
auto-merge was automatically disabled January 26, 2025 13:11

Pull request was closed

Copy link
Contributor Author

mergify bot commented Jan 26, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@murphyatwork murphyatwork reopened this Jan 27, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 27, 2025 01:20
(cherry picked from commit 3ac86d6)
Signed-off-by: Murphy <[email protected]>

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/statistic/StatisticsCollectionTrigger.java
@murphyatwork murphyatwork force-pushed the mergify/bp/branch-3.2/pr-55433 branch from 9bca4db to 3a0e31f Compare January 27, 2025 01:21
@wanpengfei-git wanpengfei-git merged commit 24f290e into branch-3.2 Jan 27, 2025
31 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-55433 branch January 27, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants