Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix backend crash due to _immutable_partition_ids unsafe concurrent access (backport #55085) #55454

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 26, 2025

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…current access (#55085)

Signed-off-by: meegoo <[email protected]>
(cherry picked from commit b4b3ce8)

# Conflicts:
#	be/src/runtime/lake_tablets_channel.cpp
#	be/src/runtime/local_tablets_channel.h
@mergify mergify bot added the conflicts label Jan 26, 2025
Copy link
Contributor Author

mergify bot commented Jan 26, 2025

Cherry-pick of b4b3ce8 has failed:

On branch mergify/bp/branch-3.2/pr-55085
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit b4b3ce880a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/runtime/local_tablets_channel.cpp
	modified:   be/src/runtime/tablets_channel.h

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/runtime/lake_tablets_channel.cpp
	both modified:   be/src/runtime/local_tablets_channel.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Jan 26, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

auto-merge was automatically disabled January 26, 2025 07:29

Pull request was closed

@meegoo meegoo reopened this Jan 26, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 26, 2025 07:32
@meegoo meegoo disabled auto-merge January 26, 2025 07:32
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 26, 2025 07:32
@wanpengfei-git wanpengfei-git merged commit 84f14bb into branch-3.2 Jan 26, 2025
26 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-55085 branch January 26, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants