Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix refresh mv with some external table bug #55372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

[BugFix] Fix refresh mv with some external table bug #55372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions fe/fe-core/src/main/java/com/starrocks/connector/partitiontraits/JDBCPartitionTraits.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@

import com.google.common.collect.Range;
import com.starrocks.analysis.Expr;
import com.starrocks.catalog.BaseTableInfo;
import com.starrocks.catalog.Column;
import com.starrocks.catalog.JDBCPartitionKey;
import com.starrocks.catalog.JDBCTable;
import com.starrocks.catalog.MaterializedView;
import com.starrocks.catalog.PartitionKey;
import com.starrocks.common.AnalysisException;
import com.starrocks.connector.PartitionInfo;
Expand All @@ -27,6 +29,7 @@
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Set;

public class JDBCPartitionTraits extends DefaultTraits {
@Override
Expand Down Expand Up @@ -66,5 +69,18 @@ public Optional<Long> maxPartitionRefreshTs() {
.map(com.starrocks.connector.PartitionInfo::getModifiedTime)
.max(Long::compareTo);
}

@Override
public Set<String> getUpdatedPartitionNames(List<BaseTableInfo> baseTables,
MaterializedView.AsyncRefreshContext context) {

try {
return super.getUpdatedPartitionNames(baseTables, context);
} catch (Exception e) {
// some external table traits do not support getPartitionNameWithPartitionInfo, will throw exception,
// just return null
return null;
}
}
}

LiShuMing marked this conversation as resolved.
Show resolved Hide resolved
Loading