[BugFix] Prune aggregate non-required columns after mv transparent rewrite #55286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
.../com/starrocks/sql/optimizer/rule/transformation/materialization/MvPartitionCompensator.java
Show resolved
Hide resolved
...ain/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MVColumnPruner.java
Show resolved
Hide resolved
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
LiShuMing
force-pushed
the
fix_transparent_union_rewrite.v1
branch
from
fdd6c86 to
728177f
Compare
Signed-off-by: shuming.li <[email protected]>
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 58 / 58 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
kangkaisen
approved these changes
Jan 22, 2025
satanson
approved these changes
Jan 22, 2025
|
@Mergifyio backport branch-3.4 |
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
…write (#55286) Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 8631ba9) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvTransparentRewriteWithOlapTableTest.java
Merged
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
…write (#55286) Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 8631ba9) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/operator/OpRuleBit.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/MaterializedViewTransparentRewriteRule.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvPartitionCompensator.java
Merged
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jan 22, 2025
…write (backport #55286) (#55337) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jan 22, 2025
…write (backport #55286) (#55338) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Since we treat mv as always-transparent(refresh timeliness is always fine) which we use mv transparent union rewrite internally. But after rewrite, mvScanPlan and mvCompensatePlan will output all columns of the mv's defined query, it may contain more columns than the requiredColumns.
What I'm doing:
Fixes #55221
Further:
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: