Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Es6 class version #2

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

Conversation

msmfsd
Copy link

@msmfsd msmfsd commented Aug 11, 2016

This could possibly be a alt version, see how you go. Again I used the slider in my project after getting frustrating with many other react sliders - and it worked really well.

I have commented the changes and added a hide class to the CSS.

@Stanko
Copy link
Owner

Stanko commented Aug 11, 2016

Hey, thanks for the kind words and the effort. I was planning to rewrite it to ES6 and have a transpiled ES5 version as well. (Similar to what I did here, with a minimum tooling - https://github.com/stanko/sektor).

I will merge this soon. Could you please move that class to the sass file (slider.scss) and renamed it to .Hide to follow overall convention.

@msmfsd
Copy link
Author

msmfsd commented Aug 12, 2016

Have updated classname to scss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants