Skip to content

Conversation

freddierice
Copy link

Implements feature #6346, adding support for SSH Certificate Signing.

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Aug 14, 2025
@CLAassistant
Copy link

CLAassistant commented Aug 14, 2025

CLA assistant check
All committers have signed the CLA.

@danxg87
Copy link

danxg87 commented Aug 19, 2025

@fdrab it appears unit tests are all failing with the following:

ProcessExecutionFailure: Process 'Building pytest.pex' failed with exit code 1.
stdout:

stderr:
There was 1 error downloading required artifacts:
1. st2-rbac-backend 3.9.dev0 from git+https://github.com/StackStorm/st2-rbac-backend.git@master
    Expected sha256 hash of e49a85b9d1ad7cd9e75d53810ddf1e3ec50c83b1e4d8629d80f0566a233e5637 when downloading st2-rbac-backend but hashed to d34d5cbb539182553ec8b35a0763decb6b66bd37aa51f3a61db1eb30449f6f10.

is there something we need to update on our end (besides adding an entry to CHANGELOG.rst @freddierice )

@freddierice freddierice force-pushed the signed-ssh-certificates branch 2 times, most recently from 72d9cd6 to 57f50bd Compare August 19, 2025 15:14
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines. Requires some effort to review. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Aug 19, 2025
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/L PR that changes 100-499 lines. Requires some effort to review. labels Aug 19, 2025
@freddierice
Copy link
Author

I got as much green as possible by:

  • running pants fmt ::
  • bumping the hash on the new st2-rbac-backend (master will continue to change over time)

The last tests are failing due to functionality that is unrelated to this PR.

@fdrab
Copy link
Contributor

fdrab commented Aug 20, 2025

Hi. I'm not a maintainer / reviewer. I usually ignore errors that are obviously not related to the changes I've made, as the testing framework and some other components may be WIP.

@danxg87
Copy link

danxg87 commented Aug 20, 2025

Hi. I'm not a maintainer / reviewer. I usually ignore errors that are obviously not related to the changes I've made, as the testing framework and some other components may be WIP.

OH! Sorry about that haha. Thanks for the heads up on the tests. I will try to poke a reviewer/maintainer on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants