Generate secrets when container is started #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
suggested changes
May 28, 2018
There was a problem hiding this comment.
With this change we auto-generate secrets once the container starts.
The problem is that we have several containers which all will start with random SSH keys and SSL certificates, making impossible to use StackStorm web UI in several load-balances instances and SSH to remote hosts.
That's why I mentioned previously: while it's easy to fix VM like Vagrant/OVA StackStorm/packer-st2#39 with this auto-generate on boot approach, I'd say we have no easy solution for containers.
Eg. the only way for now is to explicitly note that it's user obligation to pass/share their own SSH keys and SSL certs for prod use.
vutny
reviewed
Jul 2, 2018
| @@ -64,7 +64,7 @@ for f in /st2-docker/entrypoint.d/*; do | |||
| done | |||
|
|
|||
| # 1ppc: launch entrypoint-1ppc.sh via dumb-init if $ST2_SERVICE is set | |||
| if [ ! -z ${ST2_SERVICE} ]; then | |||
| if [ ! -z ${ST2_SERVICE:-} ]; then | |||
There was a problem hiding this comment.
Wouldn't it be better to make a positive test?
if [ -n "${ST2_SERVICE:-}" ]; then
transhapHigsn
pushed a commit
to DiligenceVault/st2-docker
that referenced
this pull request
Jun 8, 2021
You can find the old deprecated version in `DEPRECATED/all-in-one` branch archive: https://github.com/StackStorm/st2-docker/tree/DEPRECATED/all-in-one Closes StackStorm#22, closes StackStorm#23, closes StackStorm#26, closes StackStorm#29, closes StackStorm#34, closes StackStorm#41, closes StackStorm#43, closes StackStorm#92, closes StackStorm#112, closes StackStorm#117, closes StackStorm#125, closes StackStorm#133, closes StackStorm#141, closes StackStorm#145, closes StackStorm#151, closes StackStorm#163, closes StackStorm#187, closes StackStorm#188, closes StackStorm#189, closes StackStorm#190 Closes StackStorm#162, closes StackStorm#138, closes StackStorm#108, closes StackStorm#102, closes StackStorm#65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See StackStorm/packer-st2#39.
Remaining tasks: