Adding in functionality to return Subtasks and Components to search_issues #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion, updated CHANGES.md
floatingstatic
requested changes
Aug 22, 2023
There was a problem hiding this comment.
One minor thing to fix in the changelog, otherwise looks good to me. I think this change makes sense given get_issues supports these two additional parameters and to_issue_dict() is already wired to accept these flags. I tested in st2-docker installing the pack from your fork and every seems to work just fine. I can approve and merge this change after fixing the version in changelog. Thanks for the contribution!
|
@floatingstatic Updated! Thanks. |
floatingstatic
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_issuecurrently has the ability to enable flags to include an issue's Subtasks and Components.However, this is also an available flag for search via the API, where you can include Subtasks and Components for issues which are returned by the JQL search query.
This PR adds the
include_subtasksandinclude_componentsflags to thesearch_issueaction. I've tested these changes locally by modifying the existing action, and there seems to be no impact on other functionality by adding these flags.CHANGES.mdhas been updated, andpack.yamlversion has been incremented to2.4.1.