Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: cleanups #132

Merged
merged 7 commits into from
Dec 29, 2021
Merged

gha: cleanups #132

merged 7 commits into from
Dec 29, 2021

Conversation

cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Dec 27, 2021

  • set FORCE_CHECK_ALL_FILES=true by default (see Remove FORCE_CHECK_ALL_FILES and always check all files #88)
  • do not obscure the pip output with pip -q. Instead we can use gha output groups to jump past it.
  • if a different branch of st2 or lint-configs is selected, then we need more than just one commit (fetch-depth: 1). So, if the branch is set to anything other than the default branch (master) then set fetch-depth: 0 so that all history gets included.

Tested at https://github.com/StackStorm-Exchange/stackstorm-test/runs/4644706724

@cognifloyd cognifloyd merged commit 03a29cc into master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants