Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FORCE_CHECK_ALL_FILES and always check all files #88

Open
blag opened this issue May 14, 2020 · 0 comments
Open

Remove FORCE_CHECK_ALL_FILES and always check all files #88

blag opened this issue May 14, 2020 · 0 comments
Assignees
@nmaludy
Labels
enhancement help wanted

Comments

@blag
Copy link
Contributor

blag commented May 14, 2020

As decided in StackStorm/community#7, we should always check all files in all CircleCI workflows.
@nmaludy nmaludy mentioned this issue Jul 31, 2020
Closed
@nmaludy nmaludy self-assigned this Jul 31, 2020
@cognifloyd cognifloyd mentioned this issue Dec 24, 2021
Merged
cognifloyd added a commit to cognifloyd/st2exchange-ci that referenced this issue Dec 27, 2021
@cognifloyd
gha: pack ci FORCE_CHECK_ALL_FILES=true by defualt
12e82ef 
part of: StackStorm-Exchange#88
@cognifloyd cognifloyd mentioned this issue Dec 27, 2021
Merged
cognifloyd added a commit that referenced this issue Dec 29, 2021
@cognifloyd
Merge pull request #132 from StackStorm-Exchange/gha
03a29cc 
gha: cleanups

- set FORCE_CHECK_ALL_FILES=true by default (see #88)
- do not obscure the pip output with `pip -q`. Instead we can use gha output groups to jump past it.
- if a different branch of st2 or lint-configs is selected, then we need more than just one commit (`fetch-depth: 1`). So, if the branch is set to anything other than the default branch (`master`) then set `fetch-depth: 0` so that all history gets included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmaludy nmaludy

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blag @nmaludy