fix: replace ethers imports with viem and add type guards

[kushbosamiya]

Problem

• ethers module has no type declarations installed, causing TS errors in 3 files
• Promise.all with early return produces (Auction | undefined)[] not assignable to Auction[] in dashboard

Changes

• Replace parseEther import from ethers → viem in english-auction-service.ts and allpay-auction-service.ts
• Replace formatEther import from ethers → viem in vickrey-commit-form.tsx
• Add type predicate (auction): auction is Auction to .filter() calls in dashboard/page.tsx

viem already exports both functions and is the primary Web3 library in this project.

Summary by CodeRabbit

• Refactor
  • Improved type safety for auction data filtering and consolidated utility function imports across services to enhance code maintainability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 096d20f and d8d4b1a.

📒 Files selected for processing (4)

• app/dashboard/page.tsx
• components/auction/vickrey-commit-form.tsx
• lib/services/allpay-auction-service.ts
• lib/services/english-auction-service.ts

---

📝 Walkthrough

Walkthrough

This pull request migrates format and parse utility imports from ethers to viem across auction-related files and adds TypeScript type predicates to filter operations in the dashboard to refine null-inclusive array types to non-null auction arrays.

Changes

Cohort / File(s)	Summary
Type Narrowing app/dashboard/page.tsx	Added type predicates using is Auction keyword to three filter calls, refining return type from (Auction | null)[] to Auction[] without altering runtime behavior.
Library Migration to viem components/auction/vickrey-commit-form.tsx, lib/services/allpay-auction-service.ts, lib/services/english-auction-service.ts	Migrated formatEther and parseEther imports from ethers to viem across multiple auction-related files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: precision loss in bid logic by using BigInt #28: Directly overlaps with the viem migration of parseEther and formatEther utilities across auction-related files.
• Integrated Web-UI with new modifications in smart-contracts #13: Modifies the same files and import/typing sites affected by these changes.

Suggested reviewers

• Zahnentferner

Poem

🐰 From ethers to viem, the imports now fly,
Type predicates narrowing, no null slips by,
Three auction files dancing in harmony,
A cleanup that's clean—as it ought to be! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the two main changes: replacing ethers imports with viem and adding type guards in filter calls.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}