Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] title, title icon 변경 및 공용 스타일 요소 파일구조 변경 #76

Merged
merged 3 commits into from
Mar 8, 2024
Merged

[Refactor] title, title icon 변경 및 공용 스타일 요소 파일구조 변경 #76

merged 3 commits into from
Mar 8, 2024

Conversation

Hooni07
Copy link
Contributor

@Hooni07 Hooni07 commented Mar 8, 2024

변경 사항

  • public/index.html에서 title 이름 및 icon 변경
    • title : Rolling
    • 팀원과 협의 후 추후 변경 가능
  • global style, reset, font, color 등의 공통 css 요소들의 directory 변경
    • assets -> styles
  • global.css, reset.css 삭제 및 styled-components 형식 통일을 위한 jsx 파일 생성
    • GlobalStyles.jsx, reset.jsx 생성 및 style 적용
  • App.js, index.js 변경

관련 이슈

#1 #61

@Hooni07 Hooni07 added Common 공통 component 및 elemnet 관련 requirement 기능별 요구사항 관련 label refactor 코드 수정, 리펙토링 및 모듈화 관련 작업 labels Mar 8, 2024
minjo0n61
minjo0n61 reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@minjo0n61 minjo0n61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전 내용 merge한 다음에 conflict 생겼나봐요! 확인부탁드려요!

@Hooni07
Copy link
Contributor Author

Hooni07 commented Mar 8, 2024

conflict 문제 해결하였습니다! 확인 부탁드려요~

minjo0n61
minjo0n61 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@minjo0n61 minjo0n61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네! 수정사항 확인 완료했습니다! 고생하셨어요!

@mangang0713 mangang0713 merged commit 49247b7 into Sprint4Team16:dev Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minjo0n61 minjo0n61 minjo0n61 approved these changes

@mangang0713 mangang0713 mangang0713 approved these changes

@gaeaeg gaeaeg Awaiting requested review from gaeaeg

@youth-o youth-o Awaiting requested review from youth-o

Assignees
No one assigned
Labels
Common 공통 component 및 elemnet 관련 refactor 코드 수정, 리펙토링 및 모듈화 관련 작업 requirement 기능별 요구사항 관련 label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hooni07 @minjo0n61 @mangang0713