Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Common(Modal)] Modal 공통 스타일 변경 및 CardModal 스타일 적용 #67

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

Hooni07
Copy link
Contributor

@Hooni07 Hooni07 commented Mar 6, 2024

변경 사항

  • ModalWindow에서 모달 공통 style 요소 수정 및 변수명 변경
  • Figma 시안과 비슷하도록 Card 클릭 시 모달 화면 나오도록 설정
  • 기타 컴포넌트명 및 변수명 변경

해결해야 할 사항

  • /edit을 통해 message 삭제 시 0.1초 동안 modal이 나오는 문제 발생
  • 모달 창 내부를 클릭하여도 모달 창이 닫히는 문제 발생

관련 이슈

#61

@Hooni07 Hooni07 added Common 공통 component 및 elemnet 관련 /post/{id} 생성된 롤링페이퍼 페이지 관련 이슈 labels Mar 6, 2024
@@ -210,6 +210,7 @@ function Card({
{isCardOpen && (
<ModalPortal>
<CardModal
onClicke={(e) => e.preventDefault()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요기 onClicke라고 되어있는데 onClick의 오타일까요?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 그렇네요 이걸 이제봤군요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗... 지금 바로 수정할게요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제꺼는 approve를 어떻게 취소하는지 모르겠네요 확인하고 마저 approve해주세요!

@Hooni07
Copy link
Contributor Author

Hooni07 commented Mar 6, 2024

오타 수정하였습니다! 지적 감사합니다!
review 재 요청하였습니다!

Copy link
Contributor

@minjo0n61 minjo0n61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네! 고생하셨습니다!

@minjo0n61 minjo0n61 merged commit 409ef0b into Sprint4Team16:dev Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common 공통 component 및 elemnet 관련 /post/{id} 생성된 롤링페이퍼 페이지 관련 이슈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants