perf: switch icon CDN from GitHub raw to jsDelivr #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses jsDelivr CDN which wraps GitHub with better infrastructure: - Global CDN with multiple edge locations - Better caching and rate limiting - More reliable for high-traffic sites Closes #23
celticr
commented
Jan 12, 2026
Contributor
Author
celticr
left a comment
celticr
left a comment
There was a problem hiding this comment.
Review: PR #39 - Switch icon CDN from GitHub raw to jsDelivr
Summary
Clean, minimal change that improves CDN reliability.
Issues Found
None - This is a well-scoped, safe change.
Analysis
| Aspect | Assessment |
|---|---|
| Correctness | ✅ URL format is valid for jsDelivr |
| Security | ✅ Uses HTTPS, no data handling changes |
| Performance | ✅ Improves CDN edge distribution |
| Backwards compat | ✅ Drop-in replacement, same icons served |
Notes
- jsDelivr URL format
cdn.jsdelivr.net/gh/{owner}/{repo}@{ref}/{path}is correct - Using
@mainwill always fetch latest from main branch - Consider using a tagged version (
@v1.0.3) for cache stability in future
Tests
- Ran PHPUnit: 30 tests passing
- Verified URL format produces valid icon URLs
Recommendation: APPROVE ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
raw.githubusercontent.comtocdn.jsdelivr.netBenefits
Test plan
Closes #23