Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix re-rendering issue when connecting for the first time #180

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

briareus-the-titan
Copy link

PR should close #177

Description

If you connect your wallet for the first time, nothing happens. This was because react wasn't re-rendering after wagmi and rainbows initial connect.

I've also added a rule to eslint that should be helpful. LMK if you don't like that and I'll remove it

https://www.loom.com/share/fe78d31f5ca847dbbe83333ab7375ef5

@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for sporosdaoapp-dev ready!

Name Link
🔨 Latest commit 199bff2
🔍 Latest deploy log https://app.netlify.com/sites/sporosdaoapp-dev/deploys/637d7d3fcad5f40009d690b0
😎 Deploy Preview https://deploy-preview-180--sporosdaoapp-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@ivelin ivelin temporarily deployed to sweat-token-bugfix-conn-fztshs November 23, 2022 01:42 Inactive
@briareus-the-titan
Copy link
Author

I'll fix up tests once we discuss this direction, using the web3context like this. LMK what you think!

@ivelin ivelin temporarily deployed to sweat-token-bugfix-conn-pkn74i November 23, 2022 01:54 Inactive
@@ -0,0 +1,4 @@
# Disable React Host Check in Dev Mode
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember adding this and don't have it locally? not sure how it ended up here.

@ivelin
Copy link
Contributor

ivelin commented Nov 23, 2022

@briareus-the-titan I see you requested review, but there are failing checks still. Do you mind switching to draft PR until all checks pass.

@briareus-the-titan briareus-the-titan marked this pull request as draft November 23, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dApp requires refresh when first loading before balance shows up [BUG]
2 participants