Fix spectating of other entities not working #4251
Conversation
| } | ||
|
|
||
| thisPlayer.setCamera(thisPlayer); | ||
| thisPlayer.setCamera(thisPlayer.getCamera()); |
There was a problem hiding this comment.
This is equivalent to not calling setCamera at all. The line is here on purpose to stop spectating when changing dimension. The real problem is why is this line executed when the player is teleporting without changing dimension. I'm gonna investigate a bit.
There was a problem hiding this comment.
Turns out the method names impl$fireDimensionTransitionEvents and bridge$changeDimension are misleading. They are called for all teleports but have special treatment for actual dimension changes.
There was a problem hiding this comment.
Your fix causes positioning issues when spectating an entity and then teleporting. Whereas in pure vanilla it just stops spectating.
There was a problem hiding this comment.
Something worth to mention is that recent versions have changed the behavior of how passengers and spectators are teleported, and make sure we follow vanilla.
There was a problem hiding this comment.
Your fix causes positioning issues when spectating an entity and then teleporting. Whereas in pure vanilla it just stops spectating.
Nice catch! After digging into this, it seems the issue is caused because TeleportCommandMixin’s overwrite didn’t follow vanilla logic. In vanilla, the player’s camera would be set back to the player in teleportTo. I’ve opened #4252, another PR that restores the logic to match vanilla behavior.
3 participants
Requires #4252