Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated verilator chechout version from v4.216 -> v4.228 #137

Closed
wants to merge 2 commits into from

Conversation

Rishik-Y
Copy link
Contributor

@Rishik-Y Rishik-Y commented Mar 1, 2025

Info: A fix for the Github automation to work.

Sorry to make you push everytime for small things like this,
I am really trying to make this run on my NixOS,
And i cant seem to figure out where exactly is my verilated.h in the main.cpp in the test file is exactly going even though i have manually added it in the makefile.
So thought i might atleast figure out if i fix this.

@Rishik-Y
Copy link
Contributor Author

Rishik-Y commented Mar 1, 2025

I am glad that the version is completely fixed but I suppose Sbt is not implement in github actions yet? 😅

@Dolu1990
Copy link
Member

Dolu1990 commented Mar 1, 2025

Hi,

There is branch which is quite a bit ahead of main which should be ok with regressions :
#138

Lets see how pr #138 goes, i may solve it :)

@Rishik-Y
Copy link
Contributor Author

Rishik-Y commented Mar 1, 2025

Oh so sorry didnt see that branch, then i shall close this PR then ^^

@Rishik-Y Rishik-Y closed this Mar 1, 2025
@Rishik-Y Rishik-Y deleted the patch-1 branch March 1, 2025 11:16
@Dolu1990
Copy link
Member

Dolu1990 commented Mar 1, 2025

Oh so sorry didnt see that branch, then i shall close this PR then ^^

Ahh no worries, my bad i should have realize that updating main branch could waste everybodies time XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants