Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a with_library_path scope to Attachable #1380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MSchmidt
Copy link
Contributor

@MSchmidt MSchmidt commented Aug 1, 2024

Context

I'm working on markdown support for Spina. To show images from the library I want them to be included with this easy syntax: ![Alt](foldername/imagename) within the markdown.

Changes proposed in this pull request

This scope on Attachable helps to fetch the right images based on that syntax.

Guidance to review

Right now Spina doesn't use this scope internally. So I can see how this might not be accepted at the time. Also it's still using ILIKE because that's what the main branch does. Will change it once you merge the sql PR.

@Bramjetten
Copy link
Contributor

Bramjetten commented Aug 2, 2024

That's really really cool! Are you also looking at including a Markdown-editor (with preview?).

Really like the folder syntax.

Copy link

stale bot commented Oct 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 2, 2024
@Bramjetten
Copy link
Contributor

Not stale!

how would House (MD) fit into this?

@stale stale bot removed the stale label Oct 2, 2024
@MSchmidt
Copy link
Contributor Author

MSchmidt commented Oct 2, 2024

House is not released yet, but I guess as trix alternative for the MD Parts it would work great. We'd need to expend it with an spina image picker though. This PR is only the preparation for that.

Copy link

stale bot commented Dec 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 3, 2024
@MSchmidt
Copy link
Contributor Author

MSchmidt commented Dec 8, 2024

@Bramjetten I'm not planning to add anything to this specific PR. It's mergeable as it is though. If you feel like this method should not exist on its own feel free to close it.

@stale stale bot removed the stale label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants