Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecraft 1.20.3 snapshot support #3553

Closed
wants to merge 2 commits into from
Closed

Minecraft 1.20.3 snapshot support #3553

wants to merge 2 commits into from

Conversation

md-5
Copy link
Member

@md-5 md-5 commented Oct 21, 2023

No description provided.

@Janmm14
Copy link
Contributor

Janmm14 commented Oct 21, 2023

needs limits for reading nbt

@Outfluencer
Copy link
Collaborator

we are only reading from server, we dont need limits

@Janmm14
Copy link
Contributor

Janmm14 commented Oct 21, 2023

well then some really high limit

@xism4
Copy link
Contributor

xism4 commented Oct 21, 2023

we are only reading from server, we dont need limits

Yes, actually a limit are needed for huge data

@md-5
Copy link
Member Author

md-5 commented Oct 21, 2023

I will check, but as @Outfluencer says, I'm pretty sure all of these values are only from the server, are therefore trusted, and consistent with Vanilla, don't have limits.

EDIT: Confirmed, there are no limits on any of these packets in Vanilla

@md-5
Copy link
Member Author

md-5 commented Oct 28, 2023

Merged

@md-5 md-5 closed this Oct 28, 2023
@md-5 md-5 deleted the version/1.20.3 branch October 28, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants