Skip to content
This repository has been archived by the owner on Aug 7, 2020. It is now read-only.

Update http-screenshot.nse #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update http-screenshot.nse #6

wants to merge 1 commit into from

Conversation

d7x
Copy link

@d7x d7x commented Mar 17, 2019

Wait for the scan to complete and put a screenshot in /tmp/ using gnome-screenshot, use 64-bit wkhtmltoimage.

Wait for the scan to complete and put a screenshot in /tmp/ using gnome-screenshot, use 64-bit wkhtmltoimage.
@PolarBearGod
Copy link

Just following this repo but was curious:
The post operation uses Gnome Screenshot which is not universal across all *nix desktop environments - is there any particular reason to add it considering all of the other DEs?
Also why forcefully use the 64 bit version of wkhtmltoimage? i386 works on both x86 and x64 architecture giving better cross capability.

@d7x
Copy link
Author

d7x commented Mar 20, 2019

@PolarBearGod the changes proposed are not the best option regarding compatibility, but these are the changes I made because of the screenshot not waiting for the scan to complete on slow scans. The main change is the post rule added, and it could actually still use wkhtmltoimage. The changes suggested are mostly suited to the average environment used and per my own preference, so for compatibility the gnome-screenshot could be substituted with the original author's decision.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants