Skip to content

Spellflags fix reorganization #1255 #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

GladieUO
Copy link
Contributor

Regarding this issue, #1255 I think the issue is the length of the flags, I looked through the other flags and seems like there has been free 2 spaces.
I moved the two new ones there and now they work.

Thoughts?

GladieUO added 2 commits June 18, 2024 12:39
while using EF_FollowerList
#1251
Potentialy fixed two new flags that didnt worked??
There were some free spots overseen ?
@cbnolok
Copy link
Contributor

cbnolok commented Jul 3, 2024

Which def do you have in your scripts for no_elementalengine and randomdecay? Because the code in the source seems legit and for some reason those flags aren't yet been added in the x scriptpack

@GladieUO
Copy link
Contributor Author

GladieUO commented Jul 3, 2024

Which def do you have in your scripts for no_elementalengine and randomdecay? Because the code in the source seems legit and for some reason those flags aren't yet been added in the x scriptpack

It was added by xwerox by one of the monstrous PRs 😁 We probably forgot to add it in Xpack but I added it to mine scripts from changelog. I assumed its working, but few days ago find out sphere doest see it if set.
image
image

spellflag_field_randomdecay 0100000000// to randomize field timers like old sphere versions.
spellflag_no_elementalengine 0200000000 // for ignoring Elemental Engine Damages in specific spells.

NEWLY:
spellflag_field_randomdecay 00002000 // to randomize field timers like old sphere versions.
spellflag_no_elementalengine 00004000 // for ignoring Elemental Engine Damages in specific spells.

This reverts commit fa87433.
@GladieUO
Copy link
Contributor Author

Removed followerslots fix from this PR.

@cbnolok cbnolok merged commit 2522987 into Sphereserver:master Aug 6, 2024
@GladieUO GladieUO deleted the spellflags-fix-reorganization branch August 10, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants