RMS-8495: Komprise Memory leak #618
Merged
scribe merged 5 commits intoSpectraLogic:masterfrom Sep 15, 2023
Merged
Conversation
Contributor
Author
|
Looks like I have a merge issue merging with master. Time to clean it up. |
|
@scribe Seems like 99% of the changes are converting: Is this really necessary? |
Contributor
Author
If an inner class is not static it needs to be GC'd before the outer class can be marked for GC. What I'm worried about is something we return the lives a long time that keeps the outer class from going away. |
RachelTucker
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some work with a profiler detected a handful of issues:
Arrays.asList(new String[] {}withCollections.emptyList()to avoid unnecessary allocationsnew Function<…>with static classes to allow the GC to run correctlyArrays.asListwithList.ofwhich should bound allocationCharset.forName("UTF-8")which requires a parser withStandardCharsets.UTF_8which does not.All of these together have left the profiler graphs in significantly better shape.
Edit: I ran tests on my laptop but I really want to see the tests run in Jenkins to give me better feelings.