Open
Conversation
Collaborator
Author
|
Hello @suvorovrain and @georgiy-belyanin can you look at this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds SPARQL query parsing capabilities to pathrex using the
spargebracrate. We are trying to support SELECT queries with a single triple pattern in the WHERE clause. For example:spargebra is an excellent crate that provides production ready parser but we have to add some extra processing after we applied their parser.
Query Validation: We validate that the parsed query is a
SELECTquery (notASK,CONSTRUCT, orDESCRIBE).Pattern Extraction: We extract exactly one triple or property path pattern from the
WHEREclause. Queries with multiple patterns or complex BGPs are rejected.Desugaring Sequences:
spargebradesugars sequence paths like?x <a>/<b>/<c> ?yinto a chain of BGP triples with intermediate blank nodes. We reconstruct these back into a singlePropertyPathExpression::Sequencefor our RPQ evaluators.Subject/Object Validation: We ensure subjects and objects are either variables or named nodes (literals and blank nodes are not supported as they don't make sense for RPQ evaluation).
The pr closes #2