TASK-5830: TLSRPT #791
Open
TASK-5830: TLSRPT #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for support-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
deepakpn
approved these changes
May 13, 2025
approved
kkelley1
reviewed
May 14, 2025
| in the RFC: https://datatracker.ietf.org/doc/html/rfc8460. | ||
|
|
||
| The following JSON fields are not defined in the RFC: | ||
| * `epoch` - timestamp in epoch of when the hook is invoked |
There was a problem hiding this comment.
(nit) wording seems a little awkward. Maybe "epoch time" or "UNIX epoch"?
|
|
||
| The following JSON fields are not defined in the RFC: | ||
| * `epoch` - timestamp in epoch of when the hook is invoked | ||
| * `type` - whether the data is for a successful TLS connection or a failure. |
There was a problem hiding this comment.
Why 'type' rather than maybe 'status' or 'success'?
| The following JSON fields are not defined in the RFC: | ||
| * `epoch` - timestamp in epoch of when the hook is invoked | ||
| * `type` - whether the data is for a successful TLS connection or a failure. | ||
| `0` - failure; `1` - success |
There was a problem hiding this comment.
FYI, these end up on the same line in the preview.
Comment on lines
+87
to
+88
| This hook returns `int`, but for now the return value has no significance, i.e. it is not checked in | ||
| the caller. |
There was a problem hiding this comment.
I'd drop the "i.e. ..." clause.
Comment on lines
+92
to
+93
| This hook could be called in any thread. Please avoid to do time consuming tasks in the hook's | ||
| implementation. |
There was a problem hiding this comment.
I'd suggest "... avoid doing time ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
How To Test or Verify
PR Checklist
Below are some checklists to follow for the correct procedure in different circumstance. The first list ("All PRs Checklist") should be followed for ALL PRs. The next 2 are additive to this list depending on what type of PR you are using.
For example: If you are submitting a content change to one of the support documents, your checklist would include the:
If you are submitting a feature addition, enhancement, or bug fix, your checklist would include the:
All PRs Checklist
team-FEorteam-SAZ)Content Changes Checklist
examples/article.mdin the root of the project directory and on the momentum doc's preface articleDevelopment Changes Checklist (some checks are automatic github actions and will not be listed here. ie. "all tests pass")
cypress/directory in the root of the project