Fix QA

Spaghetti-Dojo · Nov 24, 2023 · e8a0309 · e8a0309
1 parent fe40b8c
commit e8a0309
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 82 deletions.
diff --git a/sources/js/src/components/composite-posts-post-types.tsx b/sources/js/src/components/composite-posts-post-types.tsx
@@ -23,18 +23,19 @@ export function CompositePostsPostTypes<P, T>(
 	};
 
 	const onChangePostType = (postType: T) => {
+		searchPostsByPostType('', postType);
 		setState({ ...state, postType, posts: Set([]) });
 		props.postType.onChange(postType);
 		props.posts.onChange(Set([]));
 	};
 
-	const searchPostsByPostType = async (phrase: string) => {
+	const searchPostsByPostType = async (phrase: string, postType: T) => {
 		if (!isFunction(props.searchPosts)) {
-			return Promise.resolve(Set([]));
+			return Promise.resolve(Set(props.posts.options));
 		}
 
 		return props
-			.searchPosts(phrase, state.postType)
+			.searchPosts(phrase, postType)
 			.then((newOptions) => {
 				const immutableOptions = Set(newOptions);
 				setPostsOptions(immutableOptions);
@@ -48,8 +49,9 @@ export function CompositePostsPostTypes<P, T>(
 	};
 
 	useEffect(() => {
-		searchPostsByPostType('');
-	}, [state.postType]);
+		searchPostsByPostType('', state.postType);
+		// eslint-disable-next-line react-hooks/exhaustive-deps
+	}, []);
 
 	const posts: EntitiesSearch.PostsControl<P> = {
 		...props.posts,

diff --git a/sources/js/src/components/post-type-radio.tsx b/sources/js/src/components/post-type-radio.tsx
@@ -11,9 +11,10 @@ export function PostTypeRadio(
 		<div className={className}>
 			{props.options.map((option) => (
 				<div key={option.value} className="wz-posts-toggle-item">
-					<label>
+					<label htmlFor={`wz-post-type-radio-${option.value}`}>
 						<input
 							type="radio"
+							id={`wz-post-type-radio-${option.value}`}
 							checked={props.value === option.value}
 							value={option.value}
 							onChange={(event) =>

diff --git a/sources/js/src/components/posts-toggle.tsx b/sources/js/src/components/posts-toggle.tsx
@@ -34,9 +34,10 @@ export function PostsToggle(
 		<div className={className}>
 			{props.options.map((option) => (
 				<div key={option.value} className="wz-posts-toggle-item">
-					<label>
+					<label htmlFor={`wz-post-type-toggle-${option.value}`}>
 						<input
 							type="checkbox"
+							id={`wz-post-type-toggle-${option.value}`}
 							checked={props.value?.has(option.value)}
 							value={option.value}
 							onChange={onChange}

diff --git a/sources/php/src/Modules/E2e/resources/js/post-types-example-block/index.js b/sources/php/src/Modules/E2e/resources/js/post-types-example-block/index.js
@@ -10,9 +10,7 @@ document.addEventListener('DOMContentLoaded', () => {
 
 	const {
 		searchPosts,
-		PostTypeSelect,
 		PostTypeRadio,
-		PostsSelect,
 		PostsToggle,
 		CompositePostsPostTypes,
 		useQueryViewablePostTypes,

diff --git a/tests/js/unit/utils/is-control-option.test.ts b/tests/js/unit/utils/is-control-option.test.ts