Composite kind type violation

The composite component shall not deal with single `kind` values. Update components documentation
Spaghetti-Dojo · Feb 24, 2024 · e8397c1 · e8397c1
1 parent ca48137
commit e8397c1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/docs/components.md b/docs/components.md
@@ -176,6 +176,7 @@ export function MyComponent(props) {
                 />
                 <ToggleControl
                     value={entities.value}
+                    options={entities.options}
                     onChange={entities.onChange}
                 />
             </>
@@ -206,8 +207,8 @@ export function MyComponent(props) {
             <>
                 <RadioControl
                     value={kind.value.first()}
-                    options={Array.from(kind.options)}
-                    onChange={kind.onChange}
+                    options={kind.options}
+                    onChange={(value) => kind.onChange(new Set([value]))}
                 />
                 /* ... */
             </>

diff --git a/sources/client/src/components/composite-entities-by-kind.tsx b/sources/client/src/components/composite-entities-by-kind.tsx
@@ -83,29 +83,28 @@ export function CompositeEntitiesByKind< E, K >(
 	};
 
 	const onChangeKind = ( kind: EntitiesSearch.Kind< K > ) => {
-		const _kind = kind instanceof Set ? kind : new Set( [ kind ] );
 		const emptySet = new Set< any >();
 
-		props.kind.onChange( _kind );
+		props.kind.onChange( kind );
 		props.entities.onChange( emptySet );
 
-		if ( _kind.length() <= 0 ) {
+		if ( kind.length() <= 0 ) {
 			dispatch( {
 				type: 'CLEAN_ENTITIES_OPTIONS',
 			} );
-			dispatch( { type: 'UPDATE_KIND', kind: _kind } );
+			dispatch( { type: 'UPDATE_KIND', kind } );
 			return;
 		}
 
 		props
-			.searchEntities( state.searchPhrase, _kind, {
+			.searchEntities( state.searchPhrase, kind, {
 				exclude: state.entities,
 			} )
 			.then( ( entitiesOptions ) => {
 				dispatch( {
 					type: 'UPDATE_ENTITIES_OPTIONS_FOR_NEW_KIND',
 					entitiesOptions,
-					kind: _kind,
+					kind,
 				} );
 			} )
 			.catch( ( error ) => {