feat: initial sov-snap implementation #1
Conversation
| }); | ||
|
|
||
| case 'signMessage': { | ||
| const { message, curve, ...params } = request.params as SignMessageParams; |
There was a problem hiding this comment.
This destructuring doesn't look like it's behaving as expected. The message isn't being displayed correctly in the snap, and signing seems to be failing
There was a problem hiding this comment.
The domain of frontend development hehehe. I developed this under Firefox Beta, and it worked. I'll check for a more compatible way, as this is part of the snap
There was a problem hiding this comment.
I tested the last commit with chromium and it worked. Did you use a Metamask Flask for the local test site? Vanilla Metamask doesn't have the functionality required to start the site - however, it works fine with the Snap
There was a problem hiding this comment.
Yep, this was with Metamask Flask on Chrome
|
This looks pretty plausible to me overall, but I ran into some errors when I actually tried to run it. Lmk if you're not able to reproduce! (I was on Chrome, MacOS, aarch64) |
There was a problem hiding this comment.
Looks good! I left some comments. One is about CI testing (it would be nice to keep it enabled, if it doesn't break our setup), the others are about code quality/security and defensive compilerOptions. These are mainly relevant for snap, whereas site looks good to me (and it's intended to be a demo, so that's fine).
Feel free to address here or track in separate issues, as long as we keep an eye on all potential problems. If you want to track these in separate issues just let me know, and I'll approve as-it-is.
Thanks for the research and the work done on this, it's an excellent start!
No description provided.