Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Visual Effects on tvOS #574

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

asshoffm
Copy link
Contributor

@asshoffm asshoffm commented Jul 7, 2024

Hello 👋

We now show the GDPR Privacy Manager in our tvOS app 👍🏻

There are two minor UI imperfections that we want to improve with this MR:

  • Unsharp border of SPAppleTVButton
  • Readability and background color of GDPR category cells

I hope the commit messages and the following screenshots provide enough information for you.

Before After

…ound images for the normal and focused state. In addition, clear the background color of all subviews to only have the wanted background image and to fix the "unsharp" border caused by `_UIFloatingContentCornerRadiusAnimatingView`.
… keeping the rounded corners and focus effect (only affects tvOS >= 14). Background and text color are hardcoded for now since they are not included in view data from the backend.
@asshoffm
Copy link
Contributor Author

Hi @andresilveirah, did you already find some time to take a look? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant