DIA-2311 fix default values being returned instead of cached data #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting/getting SPGDPRConsent to the local storage the .applies attribute was lost because it was not part of the coding keys.
When setting/getting SPCCPAConsent to the local storage the .applies attribute was lost because it was not part of the coding keys.
Nevazhnovu
approved these changes
Jun 22, 2023
| import Nimble | ||
| import Quick | ||
|
|
||
| // swiftlint:disable force_try force_unwrapping |
There was a problem hiding this comment.
ayy turning off a switlint is a cheating ;)
|
@andresilveirah you received a like 👍 for the amount of tests introduced! Have you been able to fix that flaky one? |
|
@Nevazhnovu I fixed that JSON parsing one, but it seems some UI tests fail intermittently on GH. Fortunately (or unfortunately?) they pass locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that caused the SDK to return default values for user data before
onConsentReadywas called.