Make the remember_me_token cookie name configurable
#179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbuker
requested changes
Apr 4, 2019
|
|
||
| expect(User).to receive(:authenticate).with('[email protected]', 'secret', '1') { |&block| block.call(user, nil) } | ||
| expect(user).to receive(:remember_me!) | ||
| expect(user).to receive(:remember_me_token).and_return('abracadabra').twice |
There was a problem hiding this comment.
Why does this receive the token twice? I'm not very familiar with the callback system, but this looks like it might be a side-effect of the double callback bug in 0.13.0
There was a problem hiding this comment.
@athix to be honest, I copied it over from the testcase above this one. So it could be part of the double callback bug. When I remove the twice method though, it gives an error. Could it be that the double callback bug is still relevant?
robinvdvleuten
force-pushed
the
cookie-name
branch
from
9d830ec to
ab9a403
Compare
|
@athix I've implemented your remarks. Could you take a look again? |
robinvdvleuten
force-pushed
the
cookie-name
branch
from
ab9a403 to
03e4973
Compare
|
@robinvdvleuten It seems that CI failed. |
joshbuker
added
the
to be implemented in v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the default
remember_me_tokencookie name configurable to whatever seems to fit for the application.