Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio 2015 support. #28

Closed
wants to merge 1 commit into from
Closed

Visual Studio 2015 support. #28

wants to merge 1 commit into from

Conversation

dsaltares
Copy link

Adds Visual Studio 2015 solution and LvEdRenderingEngine project.
Solves issue #26.

Adds Visual Studio 2015 solution and LvEdRenderingEngine project.
@dsaltares
Copy link
Author

After 0036871, this was the last thing needed to fully support VS2015.

@dsaltares
Copy link
Author

@abeckus is this good to merge?

@abeckus
Copy link
Contributor

abeckus commented Jan 30, 2016

Hi David,
Thanks for the effort, but unfortunately I can't just do a simple merge, because our main repo is hosted in company's SVN that has different folder structures and project references.
So basically I make changes in our trunk and push them to GitHub using a custom tool that fixes up all the inconsistencies.
Ideally we should make GitHub our main repo and let everyone use it.
Another approach is to write another custom tool to reverse the process (take changes from GitHub repo and apply them to our trunk.
At this time ATF and LevelEditor are in maintenance mode. I will fix critical bugs reported by GitHub users but add new features only when requested by our internal customers.
Btw, can you tell me a bit your LevelEditor project.
What features stand out and what are the challenges (artichtectureal issues etc.)
your feedback will help me to improve LevelEditor (whenever I get a chance to work on it).

Thanks
Alan

@dsaltares
Copy link
Author

Hi @abeckus,

I understand, although it's a shame, because a project with this potential and quality could really benefit from community support. I'm not saying merge everything, but only what you guys really think could make LevelEditor better.

So, I'm part of the LibGDX team and was just experimenting with LevelEditor for a side project of mine using said framework. Nothing too serious yet.

I simply had Visual Studio 2015 and didn't want to install an older version just for the editor :-D.

@abeckus
Copy link
Contributor

abeckus commented Feb 8, 2016

Hi David,
I totally agree with you and we will look to ways to improve the workflow.
I finally got a chance to add vs2015 and thanks for posting the pull request.
currently I am testing vs2015 support in our local branch, the GitHub push will come soon.

Btw, LevelEditor looks much nicer with dark skin theme. I am thinking to make it default.
if you interested to try it out.
Click on View menu and choose Load Skin
from skin load dialog box navigate to this folder: ..\ATF\Framework\Atf.Gui.WinForms\Applications\SkinService\Skins
and open Dark.skn file.

Thanks
Alan

@dsaltares
Copy link
Author

I don't think this is relevant anymore. Closing.

@dsaltares dsaltares closed this Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants