SQSCANGHA-56 Support GitHub self-hosted runners without keytool #149
+193
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful run here
This PR uses the keytool embedded in the JRE inside the scanner, instead of relying on the
keytool
command being installed on the environment running the action.The PR also introduces QA tests checking the full SSL flow (previously QA only checked that the p12 file was in the right place).
The test is done via an nginx serving
https
port 4443 with a self-signed certificate (generated on the fly).The nginx instance forwards to a local SQ instance on port 9000.
The PR merges into
dev
(which currently points tov4.0.0
) sincemaster
should stay onv3.0.0
until December 9th.