Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPY-2434 Add pip cache to typeshed build #2251

Closed
wants to merge 2 commits into from
Closed

SONARPY-2434 Add pip cache to typeshed build #2251

wants to merge 2 commits into from

Conversation

guillaume-dequenne-sonarsource
Copy link
Contributor

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource commented Dec 16, 2024 •
edited by jira bot
Loading

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource marked this pull request as ready for review December 16, 2024 13:37
Seppli11
Seppli11 requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@Seppli11 Seppli11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to our conversion: The changes proposed are (probably) not required. However, it would make sense to include the pip cache in the cirrus job. Furthermore, typeshed is currently executed in the analyze task, which isn't currently a bottleneck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seppli11 Seppli11 Seppli11 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillaume-dequenne-sonarsource @Seppli11