SONARPY-2462: Parallelize the qa_plugin tests #2248
Conversation
Seppli11
force-pushed
the
SONARPY-2462
branch
4 times, most recently
from
46c733b to
b230586
Compare
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.RegisterExtension; | ||
| import org.sonarqube.ws.Issues; | ||
|
|
||
| import static com.sonar.python.it.plugin.TestsUtils.issues; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| @Disabled |
There was a problem hiding this comment.
Was that test not run before? And it's actually failing?
There was a problem hiding this comment.
As far as I can tell, it wasn't run before. I've tried running this test on master and it failed as well. So, it seems that it failing is not connected to changes made in this PR.
| @BeforeAll | ||
| static void startServer() { | ||
| @Test | ||
| void test() { |
There was a problem hiding this comment.
Running the test locally, the issues do look legit. We could update the assertions (I believe asserting an empty list of issue was a mistake).
We can do that here or in a separate PR, as you prefer.
There was a problem hiding this comment.
I'll change the assertion. I think it should be doable in this PR
Seppli11
force-pushed
the
SONARPY-2462
branch
from
fefaba2 to
81fd0ff
Compare
Seppli11
force-pushed
the
SONARPY-2462
branch
2 times, most recently
from
e9613cc to
cbaa5a5
Compare
Seppli11
force-pushed
the
SONARPY-2462
branch
from
cbaa5a5 to
dbcef7f
Compare
| return new ConcurrentOrchestratorExtensionBuilder(Configuration.createEnv()); | ||
| } | ||
|
|
||
| public static ConcurrentOrchestratorExtensionBuilder builder(Configuration config) { |
There was a problem hiding this comment.
This seems unused, do we need it?
There was a problem hiding this comment.
Good catch. You're right, we don't need it. thx
|
SONARPY-2462