Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPY-2432: Split build into building and testing #2236

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

Seppli11
Copy link
Contributor

@Seppli11 Seppli11 commented Dec 11, 2024

.cirrus.yml Outdated
@@ -94,10 +94,29 @@ build_task:
- git checkout
- cd -
- source cirrus-env BUILD
- regular_mvn_build_deploy_analyze -DfailStubGenerationFast=true
- regular_mvn_build_deploy_analyze -DfailStubGenerationFast=true -DskipTypshed -DskipTests=true -Dsonar.skip=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not executing the tests, could we even go one step further and not initialize the submodules?
Or do we still expect things to fail here in case of checksum mismatch?
We'll probably be able to remove the Next token here I guess?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, we don't need it here. I moved it down to the analyze_task, where we probably do need it.

@Seppli11 Seppli11 force-pushed the SONARPY-2432 branch 4 times, most recently from bd6e15d to 2aa229a Compare December 12, 2024 08:37
@Seppli11 Seppli11 force-pushed the SONARPY-2432 branch 5 times, most recently from 31758b7 to ec54ceb Compare December 12, 2024 08:52
@Seppli11 Seppli11 force-pushed the SONARPY-2432 branch 3 times, most recently from 6e1d504 to 5be5f0f Compare December 12, 2024 11:14
Base automatically changed from SONARPY-2431 to ruling-parallelization-master December 12, 2024 12:56
@Seppli11 Seppli11 force-pushed the SONARPY-2432 branch 2 times, most recently from 86e49c0 to 84cf586 Compare December 12, 2024 13:29
@Seppli11 Seppli11 force-pushed the ruling-parallelization-master branch from ef81724 to 2535acf Compare December 12, 2024 13:35
@Seppli11 Seppli11 force-pushed the SONARPY-2432 branch 2 times, most recently from c5aa790 to c0217e0 Compare December 12, 2024 14:00
@Seppli11 Seppli11 force-pushed the ruling-parallelization-master branch from 2535acf to 919136b Compare December 13, 2024 12:20
Base automatically changed from ruling-parallelization-master to master December 13, 2024 14:19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Seppli11 Seppli11 merged commit 65d16f6 into master Dec 13, 2024
11 checks passed
@Seppli11 Seppli11 deleted the SONARPY-2432 branch December 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants