-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONARPY-2432: Split build into building and testing #2236
Conversation
40df6ad
to
e17e5d5
Compare
ba5586f
to
ddecf09
Compare
a85f87c
to
747a97a
Compare
ddecf09
to
c7b1a0c
Compare
747a97a
to
f73c181
Compare
c7b1a0c
to
acecf15
Compare
.cirrus.yml
Outdated
@@ -94,10 +94,29 @@ build_task: | |||
- git checkout | |||
- cd - | |||
- source cirrus-env BUILD | |||
- regular_mvn_build_deploy_analyze -DfailStubGenerationFast=true | |||
- regular_mvn_build_deploy_analyze -DfailStubGenerationFast=true -DskipTypshed -DskipTests=true -Dsonar.skip=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're not executing the tests, could we even go one step further and not initialize the submodules?
Or do we still expect things to fail here in case of checksum mismatch?
We'll probably be able to remove the Next token here I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right, we don't need it here. I moved it down to the analyze_task, where we probably do need it.
bd6e15d
to
2aa229a
Compare
f73c181
to
d71aaa7
Compare
31758b7
to
ec54ceb
Compare
d71aaa7
to
101b8aa
Compare
6e1d504
to
5be5f0f
Compare
86e49c0
to
84cf586
Compare
ef81724
to
2535acf
Compare
c5aa790
to
c0217e0
Compare
2535acf
to
919136b
Compare
c0217e0
to
2b7ef65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2b7ef65
to
c7cb88b
Compare
Quality Gate passedIssues Measures |
SONARPY-2432