SONARPY-2430: Enable all rules in the extend ruling #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax changed slightly. However, the content has stayed the same
Seppli11
force-pushed
the
SONARPY-2430
branch
from
336214d to
ce6e3f1
Compare
Seppli11
changed the base branch from
master
to
ruling-parallelization-master
Seppli11
force-pushed
the
SONARPY-2430
branch
from
ce6e3f1 to
5cf3dcf
Compare
guillaume-dequenne-sonarsource
requested changes
Dec 11, 2024
|
|
||
| @BeforeAll | ||
| static void prepare_quality_profile() throws IOException { | ||
| List<String> ruleKeys = bugRuleKeys(); |
There was a problem hiding this comment.
We can now remove this method (and close the associated ticket, after an honorable 3 years of waiting patiently to be handled).
|
|
||
| import static java.nio.charset.StandardCharsets.UTF_8; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.sonar.python.it.RulingHelper.bugRuleKeys; | ||
| import static org.sonar.python.it.RulingHelper.getOrchestrator; | ||
|
|
||
| // Ruling test for bug rules, to ensure they are properly tested without slowing down the CI |
There was a problem hiding this comment.
Probably this comment doesn't make sense anymore.
|
guillaume-dequenne-sonarsource
approved these changes
Dec 11, 2024
Seppli11
added a commit
that referenced
this pull request
Dec 13, 2024
Seppli11
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARPY-2430
This PR tries to merge into the
ruling-parallelization-masterto not make the build onmasterslower